-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delete account feature to remove an account from the accounts file. #743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good, thanks for an amazing contribution 💪 A few smaller things to change/add but apart from that good job!
One think I'd like you to also add is delete
subcommand appendix in docs - with the description of its arguments etc. Something very similar to what's already done (you can find appendix pages for account command in docs/src/appendix/cast/account
- you can add delete.md
there :) )
Co-authored-by: Wojciech Szymczyk <wojciech.szymczyk@swmansion.com>
Hi @devnet0x , was this closed on purpose? |
Hi, no, i think it was my mistake |
…onfirmations, etc)
gm..al conversations solved, please recheck. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great 👌 just some smaller changes
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
Thanks for your advice, conversations solved and changes commited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 💯
Let's add the sections to the docs like in this pr before merging
Done, please your review @drknzz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Fix prompt with a more clear message. Co-authored-by: Wojciech Szymczyk <wojciech.szymczyk@swmansion.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job, thanks again for the contribution 🔥
Closes #498
Introduced changes
Add account delete feature to remove an account from a network in the accounts file.
Breaking changes
N/A
Checklist
CHANGELOG.md